Code review comment for lp:~alecu/ubuntuone-client/proxy-tunnel-useit

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* Could you please change this assert:

        self.assertTrue(self.spawned, "The tunnel process is started.")

to something that reflects that self.spawned is not a boolean but a list? Perhaps using assertEqual against what should actually be in the list.

* This is in live code, TUNNEL_PORT = "Tunnel port", is it correct? does no look like a port to me :-/

* This import is not alphabetically ordered: from ubuntuone.proxy import tunnel_client. Also, if I understand correctly, that import can fail with an ImportError if the user does not have the -proxy-support debian/ubuntu package installed, since the whole ubuntuone.proxy namespace will be distributed in another binary package (as far as I know).

review: Needs Fixing

« Back to merge proposal