Code review comment for lp:~alecu/ubuntuone-client/proxy-tunnel-server

Natalia Bidart (nataliabidart) wrote :

* Can't we re-use teh code from ubuntu-sso-client instead of defnining:

 +def build_proxy(settings):

?

* Most of our projects and source file use this syntax for file encoding:

# -*- coding: utf8 -*-

would you consider using that form?

* There should be spaces around the % in "HTTP/1.0 %d %s"%(code, description)

The branch looks good!

review: Needs Fixing

« Back to merge proposal