Merge lp:~alecu/ubuntu-sso-client/tx-unpack-toomany into lp:ubuntu-sso-client

[Alejandro J. Cura]

A new value was added the Secret DBus struct, let's handle it (LP: #734671).

A new value was added the Secret DBus struct (LP: #734671)

[Roberto Alsina (ralsina)]

+1

review: Approve

[Natalia Bidart (nataliabidart)]

review: Approve

=== modified file 'ubuntu_sso/utils/tests/test_txsecrets.py'
--- ubuntu_sso/utils/tests/test_txsecrets.py	2011-02-03 13:55:02 +0000
+++ ubuntu_sso/utils/tests/test_txsecrets.py	2011-04-12 14:35:48 +0000
@@ -40,6 +40,7 @@
 PROMPT_BASE_PATH = "/org/freedesktop/secrets/prompt"
 SESSION_BASE_PATH = "/org/freedesktop/secrets/session"
 COLLECTION_BASE_PATH = "/org/freedesktop/secrets/collection/"
+SAMPLE_CONTENT_TYPE = "text/plain; charset=utf8"
 
 
 class SampleMiscException(Exception):
@@ -95,6 +96,18 @@
         return True
 
 
+class AltItemMock(ItemMock):
+    """The secret in this item has a content_type."""
+
+    @dbus.service.method(dbus_interface=txsecrets.ITEM_IFACE,
+                         in_signature="o", out_signature="(oayays)")
+    def GetSecret(self, session):
+        """Retrieve the secret for this item."""
+        if self.get_secret_fail:
+            raise SampleMiscException()
+        return (session, "", self.value, SAMPLE_CONTENT_TYPE)
+
+
 class PromptMock(dbus.service.Object):
     """A prompt necessary to complete an operation."""
 
@@ -126,6 +139,7 @@
     create_item_fail = False
     locked = False
     unlock_prompts = False
+    item_mock_class = ItemMock
 
     def __init__(self, label, *args, **kwargs):
         """Initialize this instance."""
@@ -150,8 +164,8 @@
         item_label = properties[txsecrets.LABEL_PROPERTY]
         session, parameters, value = secret
         item_path = create_object_path(make_coll_path(self.label))
-        item = self.dbus_publish(item_path, ItemMock, self, item_label,
-                                 attributes, value)
+        item = self.dbus_publish(item_path, self.item_mock_class, self,
+                                 item_label, attributes, value)
         self.items.append(item)
         if self.create_item_prompt:
             prompt_path = create_object_path(PROMPT_BASE_PATH)
@@ -746,6 +760,22 @@
         self.assertEqual(value, sample_secret)
 
     @inlineCallbacks
+    def test_get_value_four_items_per_secret(self):
+        """The code works fine when the secret dbus struct has 4 items."""
+        yield self.secretservice.open_session()
+        collection_label = "sample_keyring"
+        coll = yield self.create_sample_collection(collection_label)
+        mock_coll = self.mock_service.collections[collection_label]
+        mock_coll.item_mock_class = AltItemMock
+        attr = {"key-type": "Ubuntu SSO credentials"}
+        sample_secret = "secret83!"
+        yield coll.create_item("Cucaracha", attr, sample_secret)
+        items = yield self.secretservice.search_items(attr)
+        self.assertEqual(len(items), 1)
+        value = yield items[0].get_value()
+        self.assertEqual(value, sample_secret)
+
+    @inlineCallbacks
     def test_get_value_throws_dbus_error(self):
         """The secret value is not retrieved if DBus fails."""
         yield self.secretservice.open_session()

=== modified file 'ubuntu_sso/utils/txsecrets.py'
--- ubuntu_sso/utils/txsecrets.py	2011-02-03 13:55:02 +0000
+++ ubuntu_sso/utils/txsecrets.py	2011-04-12 14:35:48 +0000
@@ -316,7 +316,7 @@
         def getsecret_handler(secret):
             """The secret for this item was found."""
             # pylint: disable=W0612
-            session, parameters, value = secret
+            value = secret[2]
             d.callback(value)
 
         self.item_iface.GetSecret(self.service.session, byte_arrays=True,