Merge lp:~alecu/ubuntu-sso-client/textfilter-quacks into lp:ubuntu-sso-client
Proposed by
Alejandro J. Cura
Status: | Merged |
---|---|
Approved by: | Alejandro J. Cura |
Approved revision: | 834 |
Merged at revision: | 832 |
Proposed branch: | lp:~alecu/ubuntu-sso-client/textfilter-quacks |
Merge into: | lp:ubuntu-sso-client |
Diff against target: |
68 lines (+1/-52) 2 files modified
ubuntu_sso/utils/tests/test_txsecrets.py (+1/-1) ubuntu_sso/utils/webclient/tests/webclient_demo.py (+0/-51) |
To merge this branch: | bzr merge lp:~alecu/ubuntu-sso-client/textfilter-quacks |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Review via email: mp+88248@code.launchpad.net |
Commit message
Fix filter that broke maverick and lucid build; removed demo script that gives lint error
Description of the change
* filters don't really need to inherit from logging.Filter, they just need to quack like it
* removed demo script since it gives a lint error when qt4reactor is not installed
To post a comment you must log in.
For the record, calling super methods from classes derived from "object" is a good thing, mostly because of multiple inheritance and the MRO.