mediaplayer-app

Merge lp:~alecu/mediaplayer-app/hide-apps-scope into lp:mediaplayer-app

  1. hide-apps-scope
  2. Merge into trunk
Proposed by Alejandro J. Cura
Status: Rejected
Rejected by: Alejandro J. Cura
Proposed branch: lp:~alecu/mediaplayer-app/hide-apps-scope
Merge into: lp:mediaplayer-app
Diff against target: 8 lines (+1/-0)
1 file modified
data/mediaplayer-app.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp:~alecu/mediaplayer-app/hide-apps-scope
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Disapprove
PS Jenkins bot continuous-integration Approve
Michał Sawicz Approve
Review via email: mp+240126@code.launchpad.net

Commit message

Don't show in the installed apps scope

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

Sounds fine as a workaround.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:303
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/241/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6320
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4235
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-amd64-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/49
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/49/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-i386-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5926
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7572
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7572/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15225
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3591
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4622
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4622/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/241/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alejandro J. Cura (alecu) wrote :

I'll be away Nov 3-7, so feel free to land this if needed.

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Since the media player will be a trusted prompt, this merge proposal is no longer needed.

review: Disapprove

Unmerged revisions

303. By Alejandro J. Cura

Don't show in the installed apps scope

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/mediaplayer-app.desktop.in.in'
2--- data/mediaplayer-app.desktop.in.in 2014-10-02 19:11:44 +0000
3+++ data/mediaplayer-app.desktop.in.in 2014-10-30 14:33:14 +0000
4@@ -11,3 +11,4 @@
5 X-Ubuntu-Gettext-Domain=mediaplayer-app
6 X-Ubuntu-Single-Instance=true
7 X-Ubuntu-Default-Department-ID=sound-video
8+OnlyShowIn=Old

Subscribers

People subscribed via source and target branches