Merge lp:~alecu/libunity/peek-searchmetadata into lp:libunity

[Alejandro J. Cura]

Expose a getter for all_metadata contents

[Michal Hruby (mhr3)]

We do not want to expose Variants to the scopes, what's the use case here supposed to be?

review: Needs Information

[Alejandro J. Cura (alecu)]

> We do not want to expose Variants to the scopes, what's the use case here
> supposed to be?

The app preview is executing an action and passing it (in the metadata dict) an error message that it gets from the download service:
http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/Dash/Apps/AppPreview.qml#L115

The scope is handling that action, but has no way to find out about the error message that comes with it: https://code.launchpad.net/~alecu/unity-scope-click/download-errors/+merge/188712

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:300
http://jenkins.qa.ubuntu.com/job/libunity-ci/124/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libunity-saucy-amd64-ci/109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libunity-saucy-armhf-ci/109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libunity-saucy-i386-ci/109/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libunity-ci/124/rebuild

review: Needs Fixing (continuous-integration)

[Michal Hruby (mhr3)]

So you need to send a hint from the Dash to the scope, so the scope can send it back to the Dash?

[Michal Hruby (mhr3)]

And that hint will be relevant for only one specific scope when used in combination with one specific preview and one specific preview action?

I think you can see where I'm going with this...

Unmerged revisions

300. By Alejandro J. Cura on 2013-10-01

Expose a getter for all_metadata contents

=== modified file 'src/unity-scope-interface.vala'
--- src/unity-scope-interface.vala	2013-09-17 17:37:36 +0000
+++ src/unity-scope-interface.vala	2013-10-01 20:25:47 +0000
@@ -405,6 +405,10 @@
     }
   }
 
+  public Variant get_value (string key) {
+    return all_metadata.get(key);
+  }
+
   public static SearchMetadata create (HashTable<string, Variant>? metadata)
   {
     var m = new SearchMetadata ();