Merge lp:~alecu/libunity/peek-searchmetadata into lp:libunity

Proposed by Alejandro J. Cura on 2013-10-01
Status: Needs review
Proposed branch: lp:~alecu/libunity/peek-searchmetadata
Merge into: lp:libunity
Diff against target: 14 lines (+4/-0)
1 file modified
src/unity-scope-interface.vala (+4/-0)
To merge this branch: bzr merge lp:~alecu/libunity/peek-searchmetadata
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing on 2013-10-01
Michal Hruby (community) 2013-10-01 Needs Information on 2013-10-01
Review via email: mp+188711@code.launchpad.net

Commit message

Expose a getter for all_metadata contents

To post a comment you must log in.
Michal Hruby (mhr3) wrote :

We do not want to expose Variants to the scopes, what's the use case here supposed to be?

review: Needs Information
Alejandro J. Cura (alecu) wrote :

> We do not want to expose Variants to the scopes, what's the use case here
> supposed to be?

The app preview is executing an action and passing it (in the metadata dict) an error message that it gets from the download service:
http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/Dash/Apps/AppPreview.qml#L115

The scope is handling that action, but has no way to find out about the error message that comes with it: https://code.launchpad.net/~alecu/unity-scope-click/download-errors/+merge/188712

Michal Hruby (mhr3) wrote :

So you need to send a hint from the Dash to the scope, so the scope can send it back to the Dash?

Michal Hruby (mhr3) wrote :

And that hint will be relevant for only one specific scope when used in combination with one specific preview and one specific preview action?

I think you can see where I'm going with this...

Unmerged revisions

300. By Alejandro J. Cura on 2013-10-01

Expose a getter for all_metadata contents

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity-scope-interface.vala'
2--- src/unity-scope-interface.vala 2013-09-17 17:37:36 +0000
3+++ src/unity-scope-interface.vala 2013-10-01 20:25:47 +0000
4@@ -405,6 +405,10 @@
5 }
6 }
7
8+ public Variant get_value (string key) {
9+ return all_metadata.get(key);
10+ }
11+
12 public static SearchMetadata create (HashTable<string, Variant>? metadata)
13 {
14 var m = new SearchMetadata ();

Subscribers

People subscribed via source and target branches