Merge lp:~alecu/libunity/peek-searchmetadata into lp:libunity
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~alecu/libunity/peek-searchmetadata | ||||
Merge into: | lp:libunity | ||||
Diff against target: |
14 lines (+4/-0) 1 file modified
src/unity-scope-interface.vala (+4/-0) |
||||
To merge this branch: | bzr merge lp:~alecu/libunity/peek-searchmetadata | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing on 2013-10-01 | |
Michal Hruby (community) | 2013-10-01 | Needs Information on 2013-10-01 | |
Review via email:
|
Commit message
Expose a getter for all_metadata contents
Alejandro J. Cura (alecu) wrote : | # |
> We do not want to expose Variants to the scopes, what's the use case here
> supposed to be?
The app preview is executing an action and passing it (in the metadata dict) an error message that it gets from the download service:
http://
The scope is handling that action, but has no way to find out about the error message that comes with it: https:/
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:300
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
Michal Hruby (mhr3) wrote : | # |
So you need to send a hint from the Dash to the scope, so the scope can send it back to the Dash?
Michal Hruby (mhr3) wrote : | # |
And that hint will be relevant for only one specific scope when used in combination with one specific preview and one specific preview action?
I think you can see where I'm going with this...
Unmerged revisions
- 300. By Alejandro J. Cura on 2013-10-01
-
Expose a getter for all_metadata contents
We do not want to expose Variants to the scopes, what's the use case here supposed to be?