Merge lp:~alcinnz/switchboard-plug-about/setting-uri into lp:~elementary-apps/switchboard-plug-about/trunk

Proposed by Adrian Cochrane
Status: Needs review
Proposed branch: lp:~alcinnz/switchboard-plug-about/setting-uri
Merge into: lp:~elementary-apps/switchboard-plug-about/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
src/Plug.vala (+1/-0)
To merge this branch: bzr merge lp:~alcinnz/switchboard-plug-about/setting-uri
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+319735@code.launchpad.net

Description of the change

Add support for your "Preferences Opening Specification" proposal.

As that proposal didn't specify any URIs to this settings pane, I chose settings://about.
Could be a useful URI for the desktop to open.

To post a comment you must log in.

Unmerged revisions

440. By Adrian Cochrane

Add support for elementary's "Preference Opening Specification" proposal.

The proposal didn't specify a URL to the about page,
but as one might be handy this plug uses settings://about

See the proposal at:
https://docs.google.com/document/d/1N0uqNtVXEFn3cLgNMeN75mP_dpMpCco-7uw5PKow-_Q/edit#heading=h.u4ymry9b5hox

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Plug.vala'
2--- src/Plug.vala 2016-11-16 17:56:55 +0000
3+++ src/Plug.vala 2017-03-13 18:54:56 +0000
4@@ -38,6 +38,7 @@
5 display_name: _("About"),
6 description: _("View operating system and hardware information"),
7 icon: "dialog-information");
8+ supported_settings["about"] = "";
9 }
10
11 public override Gtk.Widget get_widget () {

Subscribers

People subscribed via source and target branches

to all changes: