Synapse

Merge lp:~albyrock87/synapse-project/open-with-fix into lp:synapse-project

Proposed by Alberto Aldegheri on 2010-12-10

Status:	Merged
Merged at revision:	270
Proposed branch:	lp:~albyrock87/synapse-project/open-with-fix
Merge into:	lp:synapse-project
Diff against target:	0 lines
To merge this branch:	bzr merge lp:~albyrock87/synapse-project/open-with-fix
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michal Hruby		2010-12-10	Approve on 2010-12-10
Review via email: mp+43351@code.launchpad.net

Revision history for this message

Michal Hruby (mhr3) wrote on 2010-12-10:

Please load the subclasses file in the async load_all_desktop_files method (and use async methods for the loading).

Also why did you change the behaviour of get_desktop_files_for_type ()? Please keep the old one, so no changes to desktop-file-plugin are necessary.

review: Needs Fixing

272. By Alberto Aldegheri on 2010-12-10: Use async methods
273. By Alberto Aldegheri on 2010-12-10: Like mhr3 said: ow
274. By Alberto Aldegheri on 2010-12-10: Another async whoops, and clear map
275. By Alberto Aldegheri on 2010-12-10: Moved into the first loop
276. By Alberto Aldegheri on 2010-12-10: cleanups
277. By Alberto Aldegheri on 2010-12-10: cleanups, I'm a little asleep today
278. By Alberto Aldegheri on 2010-12-10: cleanups, I'm a little asleep today
279. By Alberto Aldegheri on 2010-12-10: use set
280. By Alberto Aldegheri on 2010-12-10: One yield it's better than two