gdm

Code review comment for lp:~albertomilone/gdm/lp1697882

Revision history for this message
Alberto Milone (albertomilone) wrote :

> On Wed, Jun 28, 2017 at 04:35:35PM -0000, Alberto Milone wrote:
> > > Thanks. Please could you file upstream and then add that URL into the
> patch as
> > > "Forwarded: <url>"?
> > >
> >
> > This is something that will have to be fixed in the kernel, when the Unix
> Device Memory Allocator API lands in the kernel. It will take a while. I don't
> think it's a GNOME specific problem, but we might want to work around it for
> now.
>
> Right, but it is correct that this workaround (disabling X on nvidia +
> modesetting) is not Ubuntu specific, isn't it?
>

Correct. It is how we check KMS that, with the current approach, is Ubuntu specific (because of the root privileges thing).

> gdm3 runs as root. I'm not sure if it drops permissions before getting
> to this point - I think probably not, and this is worth looking into.
>

I'm pretty sure I ran into this problem when I started working on this. I can double check, as the effort should be minimal.

« Back to merge proposal