Merge lp:~albaguirre/unity-mir/hide-surface-during-app-suspend into lp:unity-mir

[Alberto Aguirre]

Set the visibility state on the mir surface attached to the application during suspend/resume states.

By setting the visibility state (hide) of the mir surface during an appilcation suspend state, mir can avoid compositing the surface even regardless of opaqueness and alpha pixel format.

fixes: lp: #1227739

Set the visibility state on the mir surface attached to the application during suspend/resume states.

By setting the visibility state (hide) of the mir surface during an appilcation suspend state, mir can avoid compositing the surface regardless of opaqueness and alpha pixel format.

fixes: lp: #1227739

[Andreas Pokorny (andreas-pokorny)]

+ 16ff and +28 I believe you can achieve the same with less code - simply call session()->hide() and session()->show(); Additionally it would then also work for sessions that have more than one surface.

review: Needs Fixing

[Alberto Aguirre (albaguirre)]

> + 16ff and +28 I believe you can achieve the same with less code - simply call
> session()->hide() and session()->show(); Additionally it would then also work
> for sessions that have more than one surface.

Right you are; I updated the change with your suggestion.

[Andreas Pokorny (andreas-pokorny)]

review: Approve

[Gerry Boland (gerboland)]

review: Approve

[Gerry Boland (gerboland)]

@Alberto: please add in the description the review checklist questions & your answers from https://wiki.ubuntu.com/Process/Merges/Checklists/Unity-Mir

Here's my corresponding review checklist:

• Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

• Did CI run pass? If not, please explain why.
It did

[Alberto Aguirre (albaguirre)]

Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, used unity8 as a test run.

 * Did CI run pass? If not, please explain why.
I have not run it and Jenkins bot as reviewer seems to never run.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:174
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/257/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/120/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/120/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/257/rebuild

review: Needs Fixing (continuous-integration)

[lp:~albaguirre/unity-mir/hide-surface-during-app-suspend]

175. By Alberto Aguirre on 2014-02-20

Fix application manager test failure

176. By Alberto Aguirre on 2014-02-20

merge lp:unity-mir

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:176
http://jenkins.qa.ubuntu.com/job/unity-mir-ci/259/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-amd64-ci/122
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/123
        deb: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-armhf-ci/123/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-mir-trusty-i386-ci/122

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-mir-ci/259/rebuild

review: Approve (continuous-integration)

[Alberto Aguirre (albaguirre)]

Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, ran unity8; I confirmed app surfaces are not rendered when app is on resume state.

• Did CI run pass? If not, please explain why.
Yes

=== modified file 'src/modules/Unity/Application/application.cpp'
--- src/modules/Unity/Application/application.cpp	2014-01-27 11:29:44 +0000
+++ src/modules/Unity/Application/application.cpp	2014-02-20 23:59:42 +0000
@@ -171,6 +171,9 @@
         case Application::Suspended:
             if (m_state == Application::Running) {
                 session()->set_lifecycle_state(mir_lifecycle_state_will_suspend);
+
+                session()->hide();
+
                 m_suspendTimer->start(3000);
             }
             break;
@@ -181,6 +184,7 @@
             if (m_state == Application::Suspended) {
                 resume();
                 session()->set_lifecycle_state(mir_lifecycle_state_resumed);
+                session()->show();
             } else if (m_state == Application::Stopped) {
                 respawn();
                 state = Application::Starting;