Merge lp:~albaguirre/powerd/workaround-buggy-prox-sensors into lp:powerd

Proposed by Alberto Aguirre on 2015-07-29
Status: Merged
Approved by: Alberto Aguirre on 2015-07-30
Approved revision: 175
Merged at revision: 175
Proposed branch: lp:~albaguirre/powerd/workaround-buggy-prox-sensors
Merge into: lp:powerd
Diff against target: 14 lines (+5/-0)
1 file modified
src/powerd-sensors.cpp (+5/-0)
To merge this branch: bzr merge lp:~albaguirre/powerd/workaround-buggy-prox-sensors
Reviewer Review Type Date Requested Status
Kevin DuBois (community) 2015-07-29 Approve on 2015-07-30
PS Jenkins bot continuous-integration Approve on 2015-07-30
Review via email: mp+266335@code.launchpad.net

Commit message

Workaround some proximity sensors not sending their initial state.

Assume those sensors start in the FAR state.

Description of the change

Workaround some proximity sensors not sending their initial state.

Assume those sensors start in the FAR state.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Kevin DuBois (kdub) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/powerd-sensors.cpp'
2--- src/powerd-sensors.cpp 2014-06-13 15:56:20 +0000
3+++ src/powerd-sensors.cpp 2015-07-29 23:54:34 +0000
4@@ -48,6 +48,11 @@
5
6 void powerd_sensors_proximity_enable(void)
7 {
8+ //FIXME: Some proximity sensors do not
9+ //send an initial event when enabled and nothing is close
10+ //Perhaps this should be called on a timeout instead
11+ powerd_proximity_event(FALSE);
12+
13 ua_sensors_proximity_enable(prox_sensor);
14 }
15

Subscribers

People subscribed via source and target branches