Merge lp:~albaguirre/powerd/avoid-suspend-during-call into lp:powerd

Proposed by Alberto Aguirre on 2014-08-26
Status: Rejected
Rejected by: Ricardo Salveti on 2014-08-26
Proposed branch: lp:~albaguirre/powerd/avoid-suspend-during-call
Merge into: lp:powerd
Diff against target: 28 lines (+6/-0)
1 file modified
src/powerd.cpp (+6/-0)
To merge this branch: bzr merge lp:~albaguirre/powerd/avoid-suspend-during-call
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) 2014-08-26 Disapprove on 2014-08-26
PS Jenkins bot continuous-integration Approve on 2014-08-26
Review via email:

Commit message

Issue internal suspend block suspend during calls

Description of the change

Issue internal suspend block suspend during calls (LP: #1359530)

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Ricardo Salveti (rsalveti) wrote :

I think it's fine for us to hold a suspend blocker during a voicecall, but we still need to solve the general issue when using the proximity sensor.

Think about what would happen when we get an app trying to use the same proximity sensor logic. I believe currently it'll also try to suspend the device.

review: Approve
Ricardo Salveti (rsalveti) wrote :

Checking in more details, suspending is actually an expected behavior, and we should instead try to identify the issues that are currently happening on krillin when suspending instead.

Thanks for the MR though, sorry for the confusion.

review: Disapprove
Alberto Aguirre (albaguirre) wrote :

No prob, what issues are you seeing on suspend?

Unmerged revisions

141. By Alberto Aguirre on 2014-08-26

Issue internal suspend block suspend during calls

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/powerd.cpp'
--- src/powerd.cpp 2014-08-19 20:22:10 +0000
+++ src/powerd.cpp 2014-08-26 18:58:45 +0000
@@ -355,11 +355,15 @@
355 gpointer user_data)355 gpointer user_data)
357 GVariant *tmp;357 GVariant *tmp;
358 static uuid_t sys_state_cookie;
359 if (!strcmp(signal_name, "CallAdded")) {360 if (!strcmp(signal_name, "CallAdded")) {
360 struct call_data *call;361 struct call_data *call;
362 turn_display_on(TRUE, UNITY_SCREEN_REASON_NORMAL);363 turn_display_on(TRUE, UNITY_SCREEN_REASON_NORMAL);
364 request_sys_state_internal("ofono-request",
366 &sys_state_cookie, NULL);
364 call = (struct call_data *) calloc(1, sizeof(*call));368 call = (struct call_data *) calloc(1, sizeof(*call));
365 tmp = g_variant_get_child_value(parameters, 0);369 tmp = g_variant_get_child_value(parameters, 0);
@@ -397,6 +401,8 @@
397 if (g_calls == NULL)401 if (g_calls == NULL)
398 deactivate_proximity_sensor();402 deactivate_proximity_sensor();
404 clear_sys_state_internal(sys_state_cookie);
400 g_variant_unref(tmp);406 g_variant_unref(tmp);
401 }407 }


People subscribed via source and target branches