Mir

Code review comment for lp:~albaguirre/mir/fix-1427976

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not yet sure what you're trying to express, but Semaphore(Lock) seems like the wrong name.

I recall semaphore as a type of lock with a counter. The counter is the defining feature of a semaphore. And a quick search seems to support this: http://en.wikipedia.org/wiki/Semaphore_(programming)

So I think "Semaphore" is an incorrect name.

review: Needs Fixing

« Back to merge proposal