Created by Alberto Aguirre on 2015-07-31 and last modified on 2015-07-31
Get this branch:
bzr branch lp:~albaguirre/mir/allow-null-cmd-line
Only Alberto Aguirre can upload to this branch. If you are Alberto Aguirre please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Alberto Aguirre

Recent revisions

2799. By Andreas Pokorny on 2015-07-31

Allow empty cmd line in mir::options::DefaultConfiguration

2798. By Alberto Aguirre on 2015-07-31

Enable proper ABI versioning of libmirprotobuf.

By default, the protobuf compiler generates code for its descriptor and reflection system which prevents multiple versions of libmirprotobuf from being loaded simultaneously in the same process as such code runs at library init time (static initializers). One such issue is among others (all related to registration into a symbol database used for reflection):

[libprotobuf ERROR google/protobuf/descriptor_database.cc:57] File already exists in database: mir_protobuf_wire.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:1018] CHECK failed: generated_database_->Add(encoded_file_descriptor, size):
ERROR: CHECK failed: generated_database_->Add(encoded_file_descriptor, size):

We can make the protobuf compiler avoid generating such code by using the LITE_RUNTIME option; However it requires changes to avoid using protobuf defined services as they rely on the reflection system and use only "Lite" interfaces (such as MessageLite) which is the approach taken here.

It's also worth noting that google considers the "service" module deprecated: https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.service

The DisplayServer service is now defined in src/include/common/mir/protobuf/display_server.h
On the client side, mir::client::rpc::DisplayServer implements mir::protobuf::DisplayServer and provides the glue code which calls the rpc channel.

Approved by PS Jenkins bot, Alan Griffiths, Daniel van Vugt.

2797. By Alberto Aguirre on 2015-07-30

Fix hang in mir_buffer_stream_swap_buffers_sync. Fixes: https://bugs.launchpad.net/bugs/1479899.

Approved by PS Jenkins bot, Kevin DuBois.

2796. By Alan Griffiths on 2015-07-30

tests: simplify ServerDisconnect.is_detected_by_client.

Approved by Cemil Azizoglu, Alberto Aguirre, PS Jenkins bot, Kevin DuBois.

2795. By Alan Griffiths on 2015-07-29

tests: Enable FD leak detection in acceptance tests.

Approved by Alexandros Frantzis, Kevin DuBois, PS Jenkins bot.

2794. By Daniel van Vugt on 2015-07-29

Document the awkward (but improving) situation of "supported"
pixel formats. For Robert Ancell.

Approved by Alan Griffiths, PS Jenkins bot, Robert Ancell.

2793. By Alan Griffiths on 2015-07-29

tests: rename acceptance tests that abort processes (and therefore leak FDs etc) as DeathTest.

Approved by Alexandros Frantzis, Daniel van Vugt, PS Jenkins bot.

2792. By Alan Griffiths on 2015-07-29

client: fix intermittent leak of pong callback.

Approved by Alexandros Frantzis, Daniel van Vugt, PS Jenkins bot.

2791. By Alan Griffiths on 2015-07-28

examples: Don't use uninitialized memory.

Approved by PS Jenkins bot, Cemil Azizoglu.

2790. By Alan Griffiths on 2015-07-28

tests: Don't copy uninitialized memory.

Approved by PS Jenkins bot, Alexandros Frantzis.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.