Merge lp:~albaguirre/mir/add-ubsan-build-type into lp:mir

[Alberto Aguirre]

Add UBSan build type.

Invoke with -DCMAKE_BUILD_TYPE=ubsanitizer

Add UBSan build type.

Invoke with -DCMAKE_BUILD_TYPE=ubsanitizer

Adds support to create builds with the Undefined Behavior sanitizer (UBSan, -fsanitize=undefined) enabled.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3154
http://jenkins.qa.ubuntu.com/job/mir-ci/5738/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5138
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4044
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5086
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/71/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5086
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5086/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7616
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25690
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/69/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5738/rebuild

review: Approve (continuous-integration)

[Alan Griffiths (alan-griffiths)]

+ # Skip vptr checks, there seems to be missing RTTI information when linking with UBSan enabled

This is probably something we can fix. Logged as lp:1521930

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/2209/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5148
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4054
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5096/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/43
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-autolanding/43/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/43
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-autolanding/43/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5096
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5096/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7626/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25707

review: Needs Fixing (continuous-integration)

[Alexandros Frantzis (afrantzis)]

CI network failure.

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-10-16 06:12:44 +0000
+++ CMakeLists.txt	2015-12-02 00:07:27 +0000
@@ -107,6 +107,14 @@
   endif()
   set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -fsanitize=thread")
   set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fsanitize=thread")
+elseif(cmake_build_type_lower MATCHES "ubsanitizer")
+  # Skip vptr checks, there seems to be missing RTTI information when linking with UBSan enabled
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined -fno-sanitize=vptr -fno-omit-frame-pointer")
+  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=undefined -fno-sanitize=vptr -fno-omit-frame-pointer")
+  set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -fsanitize=undefined -fno-sanitize=vptr")
+  set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fsanitize=undefined -fno-sanitize=vptr")
+  # "Symbol already defined" errors occur with pre-compiled headers
+  SET(MIR_USE_PRECOMPILED_HEADERS OFF CACHE BOOL "Use precompiled headers" FORCE)
 else()
   # AddressSanitizer builds fail if we disallow undefined symbols
   set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--no-undefined")