Mir

Code review comment for lp:~albaguirre/mir/add-menu-api

  1. add-menu-api
  2. Merge into development-branch
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

> 53 + if (!mir_surface_is_valid(parent)) abort();
> 54 + if (!rect) abort();
>
> I think we need mir::require(mir_surface_is_valid(parent)) or
> MIR_REQUIRE(mir_surface_is_valid(parent)) (or similar)

Done.

« Back to merge proposal