lp:~albaguirre/media-hub/fix-using-dead-objects

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:media-hub at revision 71

Thomas Voß (community): Approve on 2014-10-10

PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-10-10

Jim Hodapp: Pending requested 2014-10-08

Diff: 93 lines (+45/-2)

3 files modified

src/core/media/gstreamer/engine.cpp (+5/-1)
src/core/media/player_implementation.cpp (+26/-0)
src/core/media/player_skeleton.cpp (+14/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1364483: /usr/bin/media-hub-server:media-hub-server: pthread_mutex_lock.c:80: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed.	Medium	Confirmed
Bug #1376352: /usr/bin/media-hub-server:6:g_mutex_clear:gst_object_finalize:g_object_unref:~Playbin:gstreamer::Engine::Private::~Private	Undecided	Fix Released

Link a bug report

Related blueprints

75. By Alberto Aguirre on 2014-10-10

Remove previous workaround - gstreamer sometimes hangs when resetting the pipeline.

74. By Alberto Aguirre on 2014-10-08

avoid state changes after client has been disconnected.

There is a potential race between getting a notification, resetting the pipeline and another instance starting, which will attempt to pause the other player instance for which its client has died.

73. By Alberto Aguirre on 2014-10-08

Specify functor type for null getter handlers

72. By Alberto Aguirre on 2014-10-08

Remove potential access to dead objects

71. By Alberto Aguirre on 2014-10-08

Ensure properties and property getters don't access dead objects.

70. By PS Jenkins bot on 2014-09-26

Releasing 2.0.0+14.10.20140926-0ubuntu1

69. By Alberto Aguirre on 2014-09-26

Fix self deadlock when clients disconnect from media::Player

When receiving a media::PlayerImplementation on_client_disconnected signal, avoid calling
remove_player_for_key within the same context as the player object may be deleted (which owns
the signal object whose destructor waits until all slots are dispatched). Fixes: 1371454
Approved by: Jim Hodapp, Thomas Voß

68. By Alberto Aguirre on 2014-09-26

Prevent dead object access by asynchronous calls to clear_wakelock in media::PlayerImplementation::Private

On an player engine state change - detached threads are launched to clear system/display wakelocks in the future.
Before those threads get a chance to execute, media::PlayerImplementation can be destroyed. By holding a weak_ptr to
 media::PlayerImplementation::Private in the launched threads, access to dead Private objects is prevented. Fixes: 1373722
Approved by: Jim Hodapp, PS Jenkins bot

67. By PS Jenkins bot on 2014-09-17

Releasing 2.0.0+14.10.20140917-0ubuntu1

66. By Alberto Aguirre on 2014-09-17

Fix wake lock state machine and subtle race conditions on wake lock refcounts. Fixes: 1368786
Approved by: Jim Hodapp, PS Jenkins bot