lp:~albaguirre/media-hub/fix-1373722

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:media-hub at revision 68

Jim Hodapp (community): Approve on 2014-09-25

PS Jenkins bot: Approve (continuous-integration) on 2014-09-25

Diff: 164 lines (+43/-22)

2 files modified

src/core/media/player_implementation.cpp (+42/-21)
src/core/media/player_implementation.h (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1373722: Potential dead object access in media::PlayerImplementation::Private

High

Fix Released

Link a bug report

Related blueprints

70. By Alberto Aguirre on 2014-09-25

document issue in code

69. By Alberto Aguirre on 2014-09-25

Ensure state change handler is not called during destruction.

68. By Alberto Aguirre on 2014-09-25

Prevent dead object access by asynchronous calls to clear_wakelock in media::PlayerImplementation::Private

On an player engine state change - detached threads are launched to clear system/display wakelocks in the future.
Before those threads get a chance to execute, media::PlayerImplementation can be destroyed. By holding a weak_ptr to
 media::PlayerImplementation::Private in the launched threads, access to dead Private objects is prevented.

67. By PS Jenkins bot on 2014-09-17

Releasing 2.0.0+14.10.20140917-0ubuntu1

66. By Alberto Aguirre on 2014-09-17

Fix wake lock state machine and subtle race conditions on wake lock refcounts. Fixes: 1368786
Approved by: Jim Hodapp, PS Jenkins bot

65. By PS Jenkins bot on 2014-09-10

Releasing 2.0.0+14.10.20140910.2-0ubuntu1

64. By PS Jenkins bot on 2014-09-10

Replaced 0replaceme with real versions.

63. By Thomas Voß on 2014-09-10

Export the per-app media player objects as proper MPRIS players. Fixes: 1260978
Approved by: Jim Hodapp, Marcus Tomlinson, Nick Dedekind

62. By Thomas Voß on 2014-09-10

Get rid of custom macros and use the ones provided by dbus-cpp.
Adjust to changes due to making org.mpris.MediaPlayer2.Player compliant to the spec.
Approved by: Jim Hodapp, Nick Dedekind, PS Jenkins bot, Marcus Tomlinson

61. By PS Jenkins bot on 2014-09-08

Releasing 1.0.0+14.10.20140908-0ubuntu1