Merge lp:~albaguirre/location-service/ensure-noexcept into lp:location-service/trunk

[Alberto Aguirre]

Ensure Engine::for_each_provider fulfills the noexcept promise

Ensure Engine::for_each_provider fulfills the noexcept promise

Log an error if the enumerator lambda throws.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:111
http://jenkins.qa.ubuntu.com/job/location-service-ci/309/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/location-service-utopic-amd64-ci/216/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/location-service-utopic-armhf-ci/216/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/location-service-utopic-i386-ci/216

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/location-service-ci/309/rebuild

review: Needs Fixing (continuous-integration)

[Thomas Voß (thomas-voss)]

LGTM.

review: Approve

=== modified file 'src/location_service/com/ubuntu/location/engine.cpp'
--- src/location_service/com/ubuntu/location/engine.cpp	2014-06-20 07:40:34 +0000
+++ src/location_service/com/ubuntu/location/engine.cpp	2014-10-03 20:02:14 +0000
@@ -136,5 +136,14 @@
 {
     std::lock_guard<std::mutex> lg(guard);
     for (const auto& provider : providers)
-        enumerator(provider.first);
+    {
+        try
+        {
+            enumerator(provider.first);
+        }
+        catch(const std::exception& e)
+        {
+            VLOG(1) << e.what();
+        }
+    }
 }