Merge lp:~alanbell/ubuntu/precise/compizconfig-settings-manager/safetyfirst into lp:ubuntu/precise/compizconfig-settings-manager

Proposed by Alan Bell
Status: Merged
Merge reported by: Didier Roche-Tolomelli
Merged at revision: not available
Proposed branch: lp:~alanbell/ubuntu/precise/compizconfig-settings-manager/safetyfirst
Merge into: lp:ubuntu/precise/compizconfig-settings-manager
Diff against target: 38 lines (+2/-10)
1 file modified
ccm/Settings.py (+2/-10)
To merge this branch: bzr merge lp:~alanbell/ubuntu/precise/compizconfig-settings-manager/safetyfirst
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Review via email: mp+90389@code.launchpad.net

Description of the change

removes slidey range widgets, because mousewheel users can accidentally use them, inadvertently breaking stuff.

To post a comment you must log in.
37. By Alan Bell

undoing slightly overzealous deleting of code

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Alan, thanks and glad to see you are the first one to act on compiz from the ubuntu-desktop discussion :)

We try to have our distro patch using a patch system, I'll do it for you this one, but please, have a look at https://wiki.ubuntu.com/PackagingGuide for the next time!

Also, the branch for the compiz package is lp:~compiz/compizconfig-settings-manager/ubuntu (it's a debian branch only). Do not hesitate to ping me on irc if you need any help for any further work :)

Oh, and btw, can you submit it upstream as well?

Thanks again for starting working on ccsm so that it will still be shippable in precise! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ccm/Settings.py'
2--- ccm/Settings.py 2011-02-24 17:39:03 +0000
3+++ ccm/Settings.py 2012-01-27 22:20:29 +0000
4@@ -441,16 +441,10 @@
5 self.NoneValue = info[0]
6 self.Adj = gtk.Adjustment(self.Get(), info[0], info[1], inc, inc*10)
7 self.Spin = gtk.SpinButton(self.Adj)
8-
9- self.Scale = gtk.HScale(self.Adj)
10-
11- self.Scale.set_update_policy(gtk.UPDATE_DISCONTINUOUS)
12- self.Scale.connect("value-changed", self.Changed)
13 self.Spin.connect("value-changed", self.Changed)
14- self.Widget = self.Scale
15+ self.Widget = self.Spin
16
17- self.Box.pack_start(self.Scale, True, True)
18- self.Box.pack_start(self.Spin, False, False)
19+ self.Box.pack_end(self.Spin, False, False)
20
21 def _Read(self):
22 self.Adj.set_value(self.Get())
23@@ -464,7 +458,6 @@
24 self.Inc = 1
25 NumberSetting._Init(self)
26 self.Spin.set_digits(0)
27- self.Scale.set_digits(0)
28
29 class FloatSetting(NumberSetting):
30
31@@ -474,7 +467,6 @@
32 self.Inc = None
33 NumberSetting._Init(self)
34 self.Spin.set_digits(4)
35- self.Scale.set_digits(4)
36
37
38 class ColorSetting(StockSetting):

Subscribers

People subscribed via source and target branches