Merge lp:~alanbell/ubiquity/fix1010179 into lp:ubiquity

Proposed by Alan Bell
Status: Merged
Merged at revision: 5506
Proposed branch: lp:~alanbell/ubiquity/fix1010179
Merge into: lp:ubiquity
Diff against target: 12 lines (+1/-1)
1 file modified
gui/gtk/stepPartAsk.ui (+1/-1)
To merge this branch: bzr merge lp:~alanbell/ubiquity/fix1010179
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+109224@code.launchpad.net

Description of the change

the lable is read out by orca and makes no sense

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Please provide a debian/changelog entry. tool `dch` can help you with this.
Something like:
  [Alan Bell]
  * Correct the use_disk label, for ATK/orca reader (LP: #1010179)

This way you will get attribution and the bug will be closed when ubiquity with that fix will be uploaded into Ubuntu archive.
Apart from that it looks good to me.
Please, note I do not have commit access, so this is comment only review.

Revision history for this message
Colin Watson (cjwatson) wrote :

LGTM too. I'll write a changelog entry for it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gui/gtk/stepPartAsk.ui'
2--- gui/gtk/stepPartAsk.ui 2012-03-06 00:04:30 +0000
3+++ gui/gtk/stepPartAsk.ui 2012-06-07 19:45:26 +0000
4@@ -327,7 +327,7 @@
5 <property name="can_focus">False</property>
6 <property name="xalign">0</property>
7 <property name="yalign">0</property>
8- <property name="label" translatable="yes">Replace Windows with Ubuntu</property>
9+ <property name="label" translatable="yes">Replace installed operating system with Ubuntu</property>
10 </object>
11 <packing>
12 <property name="expand">False</property>

Subscribers

People subscribed via source and target branches

to status/vote changes: