Code review comment for lp:~alanbell/onboard/branding

Hi Alan, the layout looks nice, I would like to add my vote for including the design.
Alas, I'm currently not in favor of directly merging the patch. I see a couple of problems with it:

1) Changing the hard-coded stroke color visually breaks the remaining layouts as well as user defined layouts we have no control over.

2) Changing the hard-coded font to Ubuntu may pose problems for distributions other than Ubuntu.

3) Forced shades of Aubergine, though nice on my eyes and suiting Natty well, may not mix well with other distributions desktops.

Here is an alternative vision:

Onboard grows "Themes". Themes separate out color information from the current layout files and allow for custom fonts, round corners, super-key symbol etc.
An Ambiance theme for Ubuntu would be included according to your design, as well as high contrast- and Onboard classic colors.

I have some time to spare currently and have started working on a prototype. There may be something usable by next week.

I realize though that an SRU for Natty is probably out of the question. In my opinion, at this point in the release cycle it may be wise to add your patch to the Ubuntu package.