Merge lp:~alanbell/compiz/fix930783 into lp:compiz/0.9.8
| Status: | Merged |
|---|---|
| Merged at revision: | 3260 |
| Proposed branch: | lp:~alanbell/compiz/fix930783 |
| Merge into: | lp:compiz/0.9.8 |
| Diff against target: |
12 lines (+1/-1) 1 file modified
plugins/mousepoll/mousepoll.xml.in (+1/-1) |
| To merge this branch: | bzr merge lp:~alanbell/compiz/fix930783 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel van Vugt | 2012-06-18 | Approve on 2012-06-22 | |
|
Review via email:
|
|||
Description of the Change
makes compiz enhanced zoom and show mouse plugins considerably smoother to use
| Daniel van Vugt (vanvugt) wrote : | # |
| Alan Bell (alanbell) wrote : | # |
good reason to fix those other bugs then! I haven't noticed any performance problems myself, CPU use doesn't change. I can try some powertop stuff to see what happens when it is idle/locked with 1ms polling time.
| Daniel van Vugt (vanvugt) wrote : | # |
By the way, polling more than once per video frame is pointless. On a 60Hz monitor, that means anything more often than (less than) 16ms. Please try raising the interval up to 10ms so it will be smooth on monitors up to 100Hz. That will still ensure mousepoll gets at least one update per frame on almost all monitors.
And please also let us know which bug(s) in launchpad this fixes. It's not bug 30783 :)
| Sam Spilsbury (smspillaz) wrote : | # |
Probably the perceived unsmoothness is because the period of the polling doesn't line up with the period of the redraw. I'm not sure about the best way to fix that, as its the polling for a changed position that causes the redraw. We'll need to have a think about it.
| Daniel van Vugt (vanvugt) wrote : | # |
Please modify the default value to 10ms. And please resubmit from a difference branch name since it's not bug 30783.
If you can find any existing bugs this branch fixes then please link them to the branch.
| Alan Bell (alanbell) wrote : | # |
typo, it was bug 930783 I will make those changes.
| Daniel van Vugt (vanvugt) wrote : | # |
Thanks. Next time please click "Resubmit proposal" so it doesn't stay in the old state of "Needs fixing" (and could be potentially overlooked).


Interesting. Though I believe there are bugs related to mousepoll where it keeps polling when it shouldn't. So this fix would make those much worse. For example: bug 961202