Code review comment for lp:~alan-griffiths/qtmir/port-to-msh-Shell

"""
587 -SurfaceConfigurator::SurfaceConfigurator()
588 -{
589 - qRegisterMetaType<MirSurfaceAttrib>("MirSurfaceAttrib");
590 -}
"""

We need to register MirSurfaceAttrib as a metatype otherwise signal-slot connections that have a parameter or this type will fail.

Please apply this patch to your branch:

""""
=== modified file 'src/modules/Unity/Application/plugin.cpp'
--- src/modules/Unity/Application/plugin.cpp 2014-10-06 11:37:56 +0000
+++ src/modules/Unity/Application/plugin.cpp 2015-02-05 09:30:09 +0000
@@ -78,6 +78,7 @@ class UnityApplicationPlugin : public QQ
         qRegisterMetaType<qtmir::Session*>("Session*");
         qRegisterMetaType<qtmir::SessionInterface*>("SessionInterface*");
         qRegisterMetaType<qtmir::SessionModel*>("SessionModel*");
+ qRegisterMetaType<MirSurfaceAttrib>("MirSurfaceAttrib");

         qmlRegisterUncreatableType<unity::shell::application::ApplicationManagerInterface>(
                     uri, 0, 1, "ApplicationManagerInterface", "Abstract interface. Cannot be created in QML");
""""