Merge lp:~alan-griffiths/platform-api/delete-dead-code-that-uses-Mir-PrivateProtobuf-API-without-ABI-break into lp:platform-api

[Alan Griffiths]

Delete obsolete implementation of clipboard.

Delete obsolete implementation of clipboard.

It uses a Mir API I want to remove.

[Alan Griffiths (alan-griffiths)]

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Not sure how to test - Gerry says this code is unused.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:276
http://jenkins.qa.ubuntu.com/job/platform-api-ci/379/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/112/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/379/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:277
http://jenkins.qa.ubuntu.com/job/platform-api-ci/380/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/113/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/113/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/380/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:278
http://jenkins.qa.ubuntu.com/job/platform-api-ci/381/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/114/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/381/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:279
http://jenkins.qa.ubuntu.com/job/platform-api-ci/382/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/115/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/115/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/115/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/382/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:280
http://jenkins.qa.ubuntu.com/job/platform-api-ci/383/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/116
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/116
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/116/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/116

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/383/rebuild

review: Approve (continuous-integration)

[Gerry Boland (gerboland)]

The removal looks ok.

However this is an ABI breaking change, so to land it we need a silo to rebuild all the packages that depend on it (20+ at last count I think). With RTM coming up, we don't need that kind of code-churn for a cosmetic change.

So we think a sane intermediary step would be to void the function bodies to prevent breaking ABI. Then later when things have calmed down, we can do the ABI break.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:278
http://jenkins.qa.ubuntu.com/job/platform-api-ci/386/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/119
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/119/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/119

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/386/rebuild

review: Approve (continuous-integration)

[Gerry Boland (gerboland)]

debian/control still has "protobuf-compiler" listed as a dependency, I expect that's unnecessary now

I guess a generic Checklist is needed for this MR too

review: Needs Fixing

[lp:~alan-griffiths/platform-api/delete-dead-code-that-uses-Mir-PrivateProtobuf-API-without-ABI-break]

279. By Alan Griffiths on 2014-10-14

Remove protobuf-compiler from Build-Depends

[Alan Griffiths (alan-griffiths)]

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
No but Gerry did

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes

[lp:~alan-griffiths/platform-api/delete-dead-code-that-uses-Mir-PrivateProtobuf-API-without-ABI-break]

280. By Alan Griffiths on 2014-10-14

merge lp:platform-api

Unmerged revisions

280. By Alan Griffiths on 2014-10-14

merge lp:platform-api

279. By Alan Griffiths on 2014-10-14

Remove protobuf-compiler from Build-Depends

278. By Alan Griffiths on 2014-10-13

Delete obsolete implementation of clipboard

=== modified file 'src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp'
--- src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp	2014-10-13 10:11:24 +0000
+++ src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp	2014-10-14 16:11:55 +0000
@@ -34,7 +34,6 @@
 #include <ubuntu/application/sensors/light.h>
 
 #include <mir_toolkit/mir_client_library.h>
-#include <mir/client/private.h>
 
 #include <stdlib.h>
 #include <assert.h>
@@ -142,18 +141,14 @@
     (void) instance;
 }
 
-void ua_ui_set_clipboard_content(void* /*content*/, size_t /*content_size*/)
+void ua_ui_set_clipboard_content(void*, size_t)
 {
-    // TODO<papi>: Fix API and implement it
-    printf("ERROR: ua_ui_set_clipboard_content() is not implemented!\n");
+    // obsolete
 }
 
-void ua_ui_get_clipboard_content(void** out_content, size_t* out_content_size)
+void ua_ui_get_clipboard_content(void**, size_t*)
 {
-    // TODO<papi>: Fix API and implement it
-    printf("ERROR: ua_ui_get_clipboard_content() is not implemented!\n");
-    *out_content = nullptr;
-    *out_content_size = 0;
+    // obsolete
 }
 
 //