Merge lp:~alan-griffiths/miral/slightly-less-broken-touch-handling into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Gerry Boland
Approved revision: 181
Merged at revision: 182
Proposed branch: lp:~alan-griffiths/miral/slightly-less-broken-touch-handling
Merge into: lp:miral
Diff against target: 49 lines (+12/-2)
2 files modified
miral-shell/canonical_window_manager.cpp (+6/-1)
miral-shell/tiling_window_manager.cpp (+6/-1)
To merge this branch: bzr merge lp:~alan-griffiths/miral/slightly-less-broken-touch-handling
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+296325@code.launchpad.net

Commit message

Touch events can set active window, don't "eat" two finger gestures

Description of the change

Touch events can set active window, don't "eat" two finger gestures

Using "four fingers" for resize isn't ideal, but eating two finger gestures is just wrong.

To post a comment you must log in.
181. By Alan Griffiths

Also applies to TilingWindowManagerPolicy

Revision history for this message
Gerry Boland (gerboland) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'miral-shell/canonical_window_manager.cpp'
2--- miral-shell/canonical_window_manager.cpp 2016-06-01 13:33:11 +0000
3+++ miral-shell/canonical_window_manager.cpp 2016-06-02 13:24:22 +0000
4@@ -621,7 +621,7 @@
5 {
6 switch (count)
7 {
8- case 2:
9+ case 4:
10 resize(cursor);
11 consumes_event = true;
12 break;
13@@ -632,6 +632,11 @@
14 break;
15 }
16 }
17+ else
18+ {
19+ if (auto const& window = tools->window_at(cursor))
20+ tools->select_active_window(window);
21+ }
22
23 old_cursor = cursor;
24 return consumes_event;
25
26=== modified file 'miral-shell/tiling_window_manager.cpp'
27--- miral-shell/tiling_window_manager.cpp 2016-06-01 13:41:49 +0000
28+++ miral-shell/tiling_window_manager.cpp 2016-06-02 13:24:22 +0000
29@@ -366,7 +366,7 @@
30 {
31 switch (count)
32 {
33- case 2:
34+ case 4:
35 resize(cursor);
36 consumes_event = true;
37 break;
38@@ -377,6 +377,11 @@
39 break;
40 }
41 }
42+ else
43+ {
44+ if (auto const& window = tools->window_at(cursor))
45+ tools->select_active_window(window);
46+ }
47
48 old_cursor = cursor;
49 return consumes_event;

Subscribers

People subscribed via source and target branches