Merge lp:~alan-griffiths/miral/improve-doxygen into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Gerry Boland
Approved revision: 578
Merged at revision: 578
Proposed branch: lp:~alan-griffiths/miral/improve-doxygen
Merge into: lp:miral
Diff against target: 27 lines (+6/-0)
2 files modified
include/miral/command_line_option.h (+5/-0)
include/miral/window_management_policy_addendum3.h (+1/-0)
To merge this branch: bzr merge lp:~alan-griffiths/miral/improve-doxygen
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+329586@code.launchpad.net

Commit message

Add a couple of missing doxygen comments

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:578
https://mir-jenkins.ubuntu.com/job/miral-ci/72/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-miral/115
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5130
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5119
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5119
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5119
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=artful/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=artful/119/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=xenial/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=xenial/119/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=zesty/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=amd64,release=zesty/119/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=artful/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=artful/119/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=xenial/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=xenial/119/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=zesty/119
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-miral/arch=i386,release=zesty/119/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/miral-ci/72/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/miral/command_line_option.h'
2--- include/miral/command_line_option.h 2017-08-16 11:13:06 +0000
3+++ include/miral/command_line_option.h 2017-08-25 09:54:58 +0000
4@@ -103,6 +103,11 @@
5 std::shared_ptr<Self> self;
6 };
7
8+/**
9+ * Update the option to be called back *before* Mir initialization starts
10+ *
11+ * \param clo the option
12+ */
13 auto pre_init(CommandLineOption const& clo) -> CommandLineOption;
14 }
15
16
17=== modified file 'include/miral/window_management_policy_addendum3.h'
18--- include/miral/window_management_policy_addendum3.h 2017-08-10 16:59:22 +0000
19+++ include/miral/window_management_policy_addendum3.h 2017-08-25 09:54:58 +0000
20@@ -46,6 +46,7 @@
21 * vertically maximized windows to allow adjustment for decorations.
22 *
23 * @param window_info the window
24+ * @param new_state the new state
25 * @param new_placement the suggested placement
26 *
27 * @return the confirmed placement of the window

Subscribers

People subscribed via source and target branches