Merge lp:~alan-griffiths/miral/fix-1675115 into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: 544
Merged at revision: 543
Proposed branch: lp:~alan-griffiths/miral/fix-1675115
Merge into: lp:miral
Diff against target: 30 lines (+20/-0)
1 file modified
miral-shell/miral-xrun.sh (+20/-0)
To merge this branch: bzr merge lp:~alan-griffiths/miral/fix-1675115
Reviewer Review Type Date Requested Status
Andreas Pokorny (community) Approve
Cemil Azizoglu (community) Approve
Alan Griffiths Abstain
Review via email: mp+320694@code.launchpad.net

Commit message

[miral-examples] Update miral-xrun to match GDK changes (LP: #1675115)

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

ok

review: Approve
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

ok

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Actually, the existing behaviour of "provide an X11 server and let the app do what it wants" isn't completely useless.

Maybe, a "-force-x11" switch would be better?

review: Needs Information
lp:~alan-griffiths/miral/fix-1675115 updated
544. By Alan Griffiths

Option to force toolkits through Xmir

Revision history for this message
Alan Griffiths (alan-griffiths) :
review: Abstain
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

lgtm

review: Approve
Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

Ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'miral-shell/miral-xrun.sh'
2--- miral-shell/miral-xrun.sh 2016-10-06 15:36:15 +0000
3+++ miral-shell/miral-xrun.sh 2017-03-24 13:04:12 +0000
4@@ -9,6 +9,26 @@
5 unset GDK_BACKEND
6 unset QT_QPA_PLATFORM
7 unset SDL_VIDEODRIVER
8+
9+while [ $# -gt 0 ]
10+do
11+ if [ "$1" == "--help" -o "$1" == "-h" ]
12+ then
13+ echo "$(basename $0) - Handy launch script for providing an Xmir X11 server"
14+ echo "Usage: $(basename $0) [options] command"
15+ echo "Options are:"
16+ echo " -force set toolkit environment variables to force X11 use"
17+ exit 0
18+ elif [ "$1" == "-force" ];
19+ then
20+ export GDK_BACKEND=x11
21+ export QT_QPA_PLATFORM=xcb
22+ export SDL_VIDEODRIVER=x11
23+ else break
24+ fi
25+ shift
26+done
27+
28 Xmir -rootless :${port} & pid=$!
29 DISPLAY=:${port} "$@"
30 kill ${pid}

Subscribers

People subscribed via source and target branches