lp:~alan-griffiths/miral/fix-1631958

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:miral at revision 403

Gerry Boland (community): Approve on 2016-10-10

Diff: 106 lines (+44/-5)

3 files modified

miral/basic_window_manager.cpp (+6/-4)
test/select_active_window.cpp (+24/-0)
test/test_window_manager_tools.h (+14/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1631958: Crash after closing Qt dialog

High

Fix Released

Link a bug report

Related blueprints

401. By Alan Griffiths on 2016-10-10

Add a test and fix another recursing scenario

400. By Alan Griffiths on 2016-10-10

Don't try to assign focus to invisible child dialogs

399. By Alan Griffiths on 2016-10-07

Add miral-xrun as a better way to use Xmir

398. By Alan Griffiths on 2016-10-07

miral-shell splash screen should be fullscreen.

397. By Gerry Boland on 2016-10-07

[miral-qt] Use WMP::window_ready as indication client has drawn its first frame, and check visible state on surface ready.

Fixes issue where MirSurface::visible was incorrect on surface creation. This was due to race between MirSurface being created and miral::WindowInfo::is_visible being called, and the client swapping a frame.

If client swapped a frame, and surface type non-hidden & non-minimized, is_visible will return true. But for same state, if no frame swapped, is_visible will return false.

So ensure we call is_visible when the surface is marked ready by MirAL.

This also replaces the term "firstFramePosted" with "ready" - we let MirAL keep track of what makes a surface "ready"

396. By Daniel d'Andrada on 2016-10-06

[miral-qt] Support maximized states not yet in MirSurfaceState

395. By Daniel d'Andrada on 2016-10-06

[miral-qt] Remove dead code: MirSurface::updateWindowInfo

Not called anywhere

394. By Alan Griffiths on 2016-10-06

A convenient overload of WindowManagerTools::modify_window() that doesn't require the WindowInfo

393. By Alan Griffiths on 2016-10-05

Introduce qtmir::PromptSessionManager to encapsulate the Mir type

392. By Alan Griffiths on 2016-10-05

[miral-qt] Remove unused CreationHints