Code review comment for lp:~alan-griffiths/miral/WindowControllerInterface-isVisible

Revision history for this message
Gerry Boland (gerboland) wrote :

Is a state getter/interpreter something that belongs in the Controller?
How do we know if the value returned by this changes?

+ const bool visible = m_controller && m_controller->isVisible(m_window);
there should always be a controller in MirSurface, no need to check for its validity.

review: Needs Information

« Back to merge proposal