Merge lp:~alan-griffiths/miral/BasicWindowManager-modify_window-doesnt-set-policy into lp:miral

[Alan Griffiths]

BasicWindowManager::modify_window() shouldn't be calling constrain_resize() - that should be a policy decision.

[Gerry Boland (gerboland)]

Won't you update the TitleBarWMPolicy or CanonicalWMPolicy the compensate? To maintain their behaviour?

[Gerry Boland (gerboland)]

review: Needs Information

[Alan Griffiths (alan-griffiths)]

> Won't you update the TitleBarWMPolicy or CanonicalWMPolicy the compensate? To
> maintain their behaviour?

TitlebarWindowManagerPolicy already calls constrain_resize(), CanonicalWindowManagerPolicy doesn't interpret input events, TilingWindowManagerPolicy does its own thing.

[Gerry Boland (gerboland)]

Ok

review: Approve

=== modified file 'miral/basic_window_manager.cpp'
--- miral/basic_window_manager.cpp	2016-09-16 11:25:07 +0000
+++ miral/basic_window_manager.cpp	2016-09-16 12:05:02 +0000
@@ -604,10 +604,7 @@
 
     if (modifications.size().is_set())
     {
-        Size new_size = modifications.size().value();
-
-        window_info.constrain_resize(new_pos, new_size);
-        place_and_size(window_info, new_pos, new_size);
+        place_and_size(window_info, new_pos, modifications.size().value());
     }
     else if (modifications.min_width().is_set() || modifications.min_height().is_set() ||
              modifications.max_width().is_set() || modifications.max_height().is_set() ||