Merge lp:~alan-griffiths/mir/workaround-1502782 into lp:mir

[Alan Griffiths]

tests: workaround for racy teardown of test case. (Which tears down drivers)

tests: workaround for racy teardown of test case. (Which tears down drivers)

[Andreas Pokorny (andreas-pokorny)]

how about adding the delay to a QuirkedBufferAllocator::~QuirkedBufferAllocator?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:3027
http://jenkins.qa.ubuntu.com/job/mir-ci/5277/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4462/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3369
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4404/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/362/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1431
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1431/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/362
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/362/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4405/console
    None: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/363/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5277/rebuild

review: Needs Fixing (continuous-integration)

[Andreas Pokorny (andreas-pokorny)]

> how about adding the delay to a
> QuirkedBufferAllocator::~QuirkedBufferAllocator?

Did that and it didnt help for the 'other' problem in lp:1506137

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:3028
http://jenkins.qa.ubuntu.com/job/mir-ci/5278/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4464
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3371
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4406
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/364/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1432
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/1432/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/364
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/364/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4407
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4407/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7043
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24239
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/365/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5278/rebuild

review: Approve (continuous-integration)

[Cemil Azizoglu (cemil-azizoglu)]

Ok

review: Approve

[Daniel van Vugt (vanvugt)]

Can't hurt..?

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/1987/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4484
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3391
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4426/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/384/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/542
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/542/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/384
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/384/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4427
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4427/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7063/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24272
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/385/console

review: Needs Fixing (continuous-integration)

[Alan Griffiths (alan-griffiths)]

Unrelated (reapproving):

+ sudo add-apt-repository --yes ppa:ci-train-ppa-service/stable-phone-overlay
Traceback (most recent call last):
  File "/usr/lib/python3.4/urllib/request.py", line 1182, in do_open
    h.request(req.get_method(), req.selector, req.data, headers)
  File "/usr/lib/python3.4/http/client.py", line 1088, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.4/http/client.py", line 1126, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.4/http/client.py", line 1084, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.4/http/client.py", line 922, in _send_output
    self.send(msg)
  File "/usr/lib/python3.4/http/client.py", line 857, in send
    self.connect()
  File "/usr/lib/python3.4/http/client.py", line 1223, in connect
    super().connect()
  File "/usr/lib/python3.4/http/client.py", line 834, in connect
    self.timeout, self.source_address)
  File "/usr/lib/python3.4/socket.py", line 494, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
  File "/usr/lib/python3.4/socket.py", line 533, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/1989/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3397
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4432/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/390/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/544
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/544/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/390
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/390/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4433
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4433/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7069/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24281
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/391/console

review: Needs Fixing (continuous-integration)

[Alan Griffiths (alan-griffiths)]

Another unrelated (and strange) failure...

Running main() from main.cpp
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from GLMark2Test
[ RUN ] GLMark2Test.benchmark_fullscreen_default
[1444988723.753888] mirplatform: Found graphics driver: android
[1444988723.754672] mirplatform: Found graphics driver: mesa-kms
[1444988723.756223] mirplatform: Found graphics driver: mesa-x11
[1444988723.756658] mirplatform: Found graphics driver: dummy
ERROR: Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_6system12system_errorEEEEE
std::exception::what: bind: No such file or directory

unknown file: Failure
C++ exception with description "Failed to start server thread" thrown in SetUp().
[ FAILED ] GLMark2Test.benchmark_fullscreen_default (10065 ms)
[----------] 1 test from GLMark2Test (10065 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (10066 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] GLMark2Test.benchmark_fullscreen_default

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/1990/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4491
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3398
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4433/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/391/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/545
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/545/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/391
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/391/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4434
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4434/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7070/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24283
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/392/console

review: Needs Fixing (continuous-integration)

[Kevin DuBois (kdub)]

alright, but lets leave the bug open so its revisited.

review: Approve

[Chris Halse Rogers (raof)]

Let's try landing this sucker *again*...

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mir-autolanding/1991/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/4515
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/3422/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/4457
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-wily-touch/415/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/546
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-autolanding/546/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/415
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-i386-ci/415/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4458
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/4458/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7093
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24324
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-wily-armhf/416/console

review: Needs Fixing (continuous-integration)

[Daniel van Vugt (vanvugt)]

6: /mir/tools/detect_fd_leaks.bash: line 84: 5536 Segmentation fault (core dumped) $@ 2>&1

Try again.

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'tests/integration-tests/graphics/android/test_android_hardware_sanity.cpp'
--- tests/integration-tests/graphics/android/test_android_hardware_sanity.cpp	2015-10-05 02:18:18 +0000
+++ tests/integration-tests/graphics/android/test_android_hardware_sanity.cpp	2015-10-15 14:28:22 +0000
@@ -281,4 +281,8 @@
     //TODO: kdub it is a bit trickier to test that a gpu can render... just check creation for now
     auto test_buffer = runner->config.the_buffer_allocator()->alloc_buffer(hw_properties);
     EXPECT_NE(nullptr, test_buffer);
+
+    // Workaround for lp:1502782
+    test_buffer.reset();
+    std::this_thread::sleep_for(std::chrono::milliseconds(10));
 }