Mir

Merge lp:~alan-griffiths/mir/support-multiple-inheritance-in-config into lp:~mir-team/mir/trunk

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 675
Proposed branch: lp:~alan-griffiths/mir/support-multiple-inheritance-in-config
Merge into: lp:~mir-team/mir/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
examples/render_surfaces.cpp (+1/-1)
include/server/mir/default_server_configuration.h (+1/-1)
To merge this branch: bzr merge lp:~alan-griffiths/mir/support-multiple-inheritance-in-config
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Review via email: mp+163156@code.launchpad.net

Commit message

config: support for multiple inheritance

Description of the change

config: support for multiple inheritance

It looks trivial, but if users of mir want to mix configuration interfaces then virtual inheritance here gives them more, better options.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/render_surfaces.cpp'
2--- examples/render_surfaces.cpp 2013-05-02 04:17:41 +0000
3+++ examples/render_surfaces.cpp 2013-05-09 16:20:32 +0000
4@@ -252,7 +252,7 @@
5 {
6 public:
7 RenderSurfacesServerConfiguration(int argc, char const** argv)
8- : mir::DefaultServerConfiguration{argc, argv}
9+ : mir::DefaultServerConfiguration(argc, argv)
10 {
11 namespace po = boost::program_options;
12
13
14=== modified file 'include/server/mir/default_server_configuration.h'
15--- include/server/mir/default_server_configuration.h 2013-05-02 00:11:18 +0000
16+++ include/server/mir/default_server_configuration.h 2013-05-09 16:20:32 +0000
17@@ -96,7 +96,7 @@
18 class Logger;
19 }
20
21-class DefaultServerConfiguration : public ServerConfiguration
22+class DefaultServerConfiguration : public virtual ServerConfiguration
23 {
24 public:
25 DefaultServerConfiguration(int argc, char const* argv[]);

Subscribers

People subscribed via source and target branches