Code review comment for lp:~alan-griffiths/mir/some-acceptance-tests-use-mir-Server-API

> typedef std::function<void(std::shared_ptr<frontend::Session> const& session)> ConnectHandler;

using ConnectHandler = ... , it's more consistent with other type definitions in the class.

> auto open_client_socket() -> int;

Although testing is a valid driver of the API, I am a bit skeptical of exposing functionality for tests only, since doing so may occasionally compromise the focus of the API, expose internals etc. This particular change seems OK, though, and if we want to provide such functionality we should also provide the same stability guarantees as we do for the "normal" public API (and stability should be an important factor in deciding whether we want a test-only method appear in the public API).

Needs fixing for the typedef.