lp:~alan-griffiths/mir/revert-3477

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

Mir CI Bot: Approve (continuous-integration) on 2016-04-27

Daniel van Vugt: Disapprove on 2016-04-27

Diff: 97 lines (+16/-52)

3 files modified

debian/mir-test-tools.install (+0/-1)
tests/performance-tests/CMakeLists.txt (+16/-9)
tests/performance-tests/performance_tests.sh (+0/-42)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3481. By Alan Griffiths on 2016-04-27

Revert -C 3477

3480. By Alan Griffiths on 2016-04-27

geometry: Make a load of stuff constexpr.

Approved by mir-ci-bot, Kevin DuBois, Cemil Azizoglu.

3479. By Kevin DuBois on 2016-04-26

client: send incoming asynchronous buffer messages directly to the mcl::Buffer object. Prepares the buffers to be allocated from the connection, instead of a chain/stream.

Change the async protocol a bit too so the RPC channel can manage the async buffers better. The RPC allocate/free buffer calls are not synchronized with the async buffer sending, so the server has to be a bit more explicit about what operation its performing, so the client side rpc channel can clean up the buffers better.

So the notification chains go from:
OBS (buffer_stream):
rpc -> buffer_stream
NBS (buffer_stream):
rpc -> buffer_stream
NBS: (presentation_chain):
rpc -> buffer_stream -> buffer

to:

OBS (buffer_stream):
rpc -> buffer_stream
NBS (buffer_stream):
rpc -> buffer -> buffer_stream
NBS: (presentation_chain):
rpc -> buffer .

Approved by mir-ci-bot, Cemil Azizoglu.

3478. By Chris Halse Rogers on 2016-04-26

Server::run(): Destroy server config after only exception processing has completed.

The server config owns all UniqueModulePtr references to all the loaded platforms.
If the server config is destroyed, then all loaded platforms will be dlclos()ed.

Since we may be handling an exception thrown from one of those DSOs, this is unsafe and can lead to a SIGEGV that appears to be stack corruption as the code it is jumping to has been unloaded.

Fixes: https://bugs.launchpad.net/mir/+bug/1553549. Fixes: https://bugs.launchpad.net/bugs/1553549.

Approved by mir-ci-bot, Daniel van Vugt, Kevin DuBois, Alan Griffiths, Cemil Azizoglu.

3477. By Daniel van Vugt on 2016-04-26

Generalise performance tests:
  * Rename mir_performance_tests to mir_glmark2_performance_test to
    show it is just a client performance test; and
  * Add a replacement script 'mir_performance_tests' that executes
    the old test but also will launch other performance tests in
    future.
.

Approved by Cemil Azizoglu, mir-ci-bot.

3476. By Kevin DuBois on 2016-04-25

client: split off the simpler groundwork code from the larger lp:~kdub/mir/notify-buffers-directly branch to reduce diff size.
1) Plumb through connection-wide the BufferFactory and SurfaceMap for the later branch to use in the BufferStream
2) provide a mechanism to cancel buffer requests in the factory
3) refine locking a bit in SurfaceMap.

Approved by Alan Griffiths, mir-ci-bot, Cemil Azizoglu.

3475. By Alberto Aguirre on 2016-04-22

Add an explicit "Virtual" display type. Fixes LP: #1573782.

Approved by Cemil Azizoglu.

3474. By Alberto Aguirre on 2016-04-22

Remove orphaned screencast sessions on disconnection

When a client disconnects either normally or due to a crash, remove any screencasts associated with the session. Fixes: https://launchpad.net/bugs/1573572

Approved by Cemil Azizoglu, mir-ci-bot.

3473. By Kevin DuBois on 2016-04-22

android: whitelist the use of EGL_KHR_fence_sync. Adreno devices have performant, non-problem-causing implementations, at the moment under hybris, other platforms need some work to get these extensions up to snuff.

Approved by mir-ci-bot, Cemil Azizoglu, Alberto Aguirre.

3472. By Chris Halse Rogers on 2016-04-22

Move ShmBuffer into new platforms/common/server path.

Approved by mir-ci-bot, Alan Griffiths, Cemil Azizoglu, Kevin DuBois, Andreas Pokorny.