Code review comment for lp:~alan-griffiths/mir/port-examples-off-obsolete-APIs

> > Looks good here, though weird alpha is ignored with render surface...
>
> There seems to be a problem with the RS API implementation.
>
> The server-side bufferstream is being created with the render surface, not
> when the stream is requested. The latter only creates the client-side object
> (without updating the server), so the pixel format cannot be respected by the
> server.

Not that the server even cares what the buffer stream alpha is:

            list.emplace_back(std::make_shared<SurfaceSnapshot>(
                info.stream, id,
                geom::Rectangle{surface_rect.top_left + info.displacement, std::move(size)},
                transformation_matrix, surface_alpha, info.stream.get()));
                                       ^^^^^^^^^^^^^