Mir

Merge lp:~alan-griffiths/mir/no-cmake-extras into lp:mir

Proposed by Alan Griffiths on 2017-10-24
Status: Merged
Approved by: Brandon Schaefer on 2017-10-24
Approved revision: 4300
Merged at revision: 4300
Proposed branch: lp:~alan-griffiths/mir/no-cmake-extras
Merge into: lp:mir
Diff against target: 11 lines (+0/-1)
1 file modified
debian/control (+0/-1)
To merge this branch: bzr merge lp:~alan-griffiths/mir/no-cmake-extras
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve on 2017-10-24
Brandon Schaefer (community) 2017-10-24 Approve on 2017-10-24
Review via email: mp+332701@code.launchpad.net

Commit message

Remove cmake-extras from debian/control

Description of the change

Remove cmake-extras from debian/control

The GMockConfig.cmake from cmake-extras doesn't work for cross-compilation, so we stopped using it.

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:4300
https://mir-jenkins.ubuntu.com/job/mir-ci/3755/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/5164/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5401
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5388
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5388
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5388
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5207/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5207
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5207/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5207/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3755/rebuild

review: Needs Fixing (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

Pre-existing problem.

11:03:52 ../../../i386-linux-gnu/crt1.o(.text+0x18): error: undefined reference to 'main'
11:03:52 collect2: error: ld returned 1 exit status
11:03:52 tests/performance-tests/CMakeFiles/mir_compositor_performance_test.dir/build.make:98: recipe for target 'bin/mir_compositor_performance_test.bin' failed
11:03:52 make[3]: *** [bin/mir_compositor_performance_test.bin] Error 1

This is racy:

target_link_libraries(mir_compositor_performance_test
  mir_system_performance_test
  ${GTEST_BOTH_LIBRARIES}
)

With no dependency on the gtest target that builds GTEST_BOTH_LIBRARIES

Brandon Schaefer (brandontschaefer) wrote :

lgtm

review: Approve
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2017-10-13 19:01:00 +0000
3+++ debian/control 2017-10-24 10:57:24 +0000
4@@ -4,7 +4,6 @@
5 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
6 XSBC-Original-Maintainer: Thomas Voß <thomas.voss@canonical.com>
7 Build-Depends: cmake,
8- cmake-extras,
9 pkg-config,
10 debhelper (>= 9),
11 doxygen,

Subscribers

People subscribed via source and target branches