(1) Setting aspect ratio the user usually just wants it fixed (video players) or completely free (say zeros). So it would ease usability if these were a single function with five parameters:
458 +bool mir_surface_spec_set_min_aspect_ratio(MirSurfaceSpec* spec, unsigned x, unsigned y) 470 +bool mir_surface_spec_set_max_aspect_ratio(MirSurfaceSpec* spec, unsigned x, unsigned y)
Similarly, when you set the resize granularity, it should be a single function instead of two:
236 +bool mir_surface_spec_set_width_inc(MirSurfaceSpec* spec, unsigned width_inc); 249 +bool mir_surface_spec_set_height_inc(MirSurfaceSpec* spec, unsigned height_inc);
Arguably all the resize constraints should be bundled into a single structure, but I think that would contradict the new design too much.
« Back to merge proposal
(1) Setting aspect ratio the user usually just wants it fixed (video players) or completely free (say zeros). So it would ease usability if these were a single function with five parameters:
458 +bool mir_surface_ spec_set_ min_aspect_ ratio(MirSurfac eSpec* spec, unsigned x, unsigned y) spec_set_ max_aspect_ ratio(MirSurfac eSpec* spec, unsigned x, unsigned y)
470 +bool mir_surface_
Similarly, when you set the resize granularity, it should be a single function instead of two:
236 +bool mir_surface_ spec_set_ width_inc( MirSurfaceSpec* spec, unsigned width_inc); spec_set_ height_ inc(MirSurfaceS pec* spec, unsigned height_inc);
249 +bool mir_surface_
Arguably all the resize constraints should be bundled into a single structure, but I think that would contradict the new design too much.