Mir

Code review comment for lp:~alan-griffiths/mir/more-surface-resize

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) Setting aspect ratio the user usually just wants it fixed (video players) or completely free (say zeros). So it would ease usability if these were a single function with five parameters:

458 +bool mir_surface_spec_set_min_aspect_ratio(MirSurfaceSpec* spec, unsigned x, unsigned y)
470 +bool mir_surface_spec_set_max_aspect_ratio(MirSurfaceSpec* spec, unsigned x, unsigned y)

Similarly, when you set the resize granularity, it should be a single function instead of two:

236 +bool mir_surface_spec_set_width_inc(MirSurfaceSpec* spec, unsigned width_inc);
249 +bool mir_surface_spec_set_height_inc(MirSurfaceSpec* spec, unsigned height_inc);

Arguably all the resize constraints should be bundled into a single structure, but I think that would contradict the new design too much.

review: Needs Fixing

« Back to merge proposal