Mir

Code review comment for lp:~alan-griffiths/mir/mir-server-with-add_configuration_option-chaining

  1. mir-server-with-add_configuration_option-chaining
  2. Merge into development-branch
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I think this mechanism offers very little (if anything) over just calling add_configuration_option() multiple times to deserve a place in our public API. Plus, I am not fond of this particular form of syntactic sugar ("add_configuration_option(x,y,z)(x,y,z)(x,y,z)...") anyway.

My vote is a non-blocking disapproval.

review: Disapprove

« Back to merge proposal