Mir

Merge lp:~alan-griffiths/mir/fix-cmake into lp:mir

Proposed by Alan Griffiths on 2017-06-08
Status: Merged
Approved by: Alan Griffiths on 2017-06-09
Approved revision: 4192
Merged at revision: 4192
Proposed branch: lp:~alan-griffiths/mir/fix-cmake
Merge into: lp:mir
Diff against target: 19 lines (+8/-1)
1 file modified
benchmarks/CMakeLists.txt (+8/-1)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-cmake
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve on 2017-06-09
Alberto Aguirre (community) 2017-06-08 Approve on 2017-06-08
Review via email: mp+325302@code.launchpad.net

Commit message

Fix CMakeLists.txt - Don't depend on conditionally non-existent targets

Description of the change

Fix CMakeLists.txt - Don't depend on conditionally non-existent targets:

valgrind not found, disabling cpu benchmarks
valgrind not found, disabling memory benchmarks
...
CMake Error at benchmarks/CMakeLists.txt:5 (add_dependencies):
  The dependency target "cpu_benchmarks" of target "benchmarks" does not
  exist.

CMake Error at benchmarks/CMakeLists.txt:5 (add_dependencies):
  The dependency target "memory_benchmarks" of target "benchmarks" does not
  exist.

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4192
https://mir-jenkins.ubuntu.com/job/mir-ci/3449/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4701
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4838
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/4828
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/4828
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4828
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4738/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4738
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4738/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3449/rebuild

review: Approve (continuous-integration)
Alberto Aguirre (albaguirre) wrote :

LGTM.

review: Approve
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/1332/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4703
    FAILURE: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1418/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1419/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4840
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/4830
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/4830
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4830
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4740/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4740
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4740/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

WTF?

DEBUG: Merging lp:~alan-griffiths/mir/fix-cmake to lp:mir
No handlers could be found for logger "bzr"
DEBUG: Commiting previous merge
Unable to obtain lock held by <email address hidden> on taotie (process #21703), acquired 24 hours, 6 minutes ago.

I don't remember acquiring that lock! (Broken it anyway)

Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'benchmarks/CMakeLists.txt'
2--- benchmarks/CMakeLists.txt 2016-01-29 08:18:22 +0000
3+++ benchmarks/CMakeLists.txt 2017-06-08 11:28:45 +0000
4@@ -2,7 +2,14 @@
5
6 add_subdirectory(cpu)
7 add_subdirectory(memory)
8-add_dependencies(benchmarks cpu_benchmarks memory_benchmarks)
9+
10+if (TARGET cpu_benchmarks)
11+ add_dependencies(benchmarks cpu_benchmarks)
12+endif ()
13+
14+if (TARGET memory_benchmarks)
15+ add_dependencies(benchmarks memory_benchmarks)
16+endif ()
17
18 if (MIR_ENABLE_TESTS)
19 # Shouldn't tests dependent things be in tests/?

Subscribers

People subscribed via source and target branches