Mir

Merge lp:~alan-griffiths/mir/fix-1728581 into lp:mir

Proposed by Alan Griffiths on 2017-10-31
Status: Rejected
Rejected by: Michał Sawicz on 2017-11-02
Proposed branch: lp:~alan-griffiths/mir/fix-1728581
Merge into: lp:mir
Diff against target: 23 lines (+1/-3)
1 file modified
examples/server_example.cpp (+1/-3)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1728581
Reviewer Review Type Date Requested Status
Michał Sawicz 2017-10-31 Resubmit on 2017-11-02
Mir CI Bot continuous-integration Approve on 2017-10-31
Review via email: mp+333025@code.launchpad.net

Commit message

[mir_demo_server] extend (not replace) the default error reporting. (LP: #1728581)

To post a comment you must log in.
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4306
https://mir-jenkins.ubuntu.com/job/mir-ci/3764/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/5187
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5424
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5411
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5411
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5411
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5230/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5230
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5230/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3764/rebuild

review: Approve (continuous-integration)
Michał Sawicz (saviq) wrote :
review: Resubmit

Unmerged revisions

4306. By Alan Griffiths on 2017-10-31

[mir_demo_server] extend (not replace) the default error reporting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/server_example.cpp'
2--- examples/server_example.cpp 2017-08-25 16:52:18 +0000
3+++ examples/server_example.cpp 2017-10-31 10:51:28 +0000
4@@ -92,6 +92,7 @@
5 void exception_handler()
6 try
7 {
8+ mir::report_exception();
9 throw;
10 }
11 catch (mir::AbnormalExit const& /*error*/)
12@@ -112,12 +113,9 @@
13 fwrite(value.c_str(), value.size(), 1, output);
14 pclose(output);
15 }
16-
17- mir::report_exception();
18 }
19 catch (...)
20 {
21- mir::report_exception();
22 }
23 }
24

Subscribers

People subscribed via source and target branches