Mir

Code review comment for lp:~alan-griffiths/mir/fix-1701308

Revision history for this message
Gerry Boland (gerboland) wrote :

I'm confused, as in eglapp.c after surface spec creation, it uses eglQuerySurface to fetch surface width & height, and has a big comment

 * Mir reserves the right to ignore our initial window dimensions and
 * resize to whatever it likes. Usually that resize callback has
 * occurred by now (see r4150), but libmirclient does not provide a
 * solid guarantee of it. Luckily, we don't care... by querying EGL
 * buffer dimensions we can get the correct answer without being
 * victim to the callback race that's going on in the background...
 * If the server has given us dimensions other than what we requested
 * then EGL will already know about it, possibly before the initial
 * resize event (!).

This patch does fix the delivery of the resize event, but as this comment says, surely the egl surface should have had the correct dimensions anyway?

review: Needs Information

« Back to merge proposal