Merge lp:~alan-griffiths/mir/fix-1641166 into lp:mir

[Alan Griffiths]

Fix code to match the documentation of CoordinateTranslator - vis "It is acceptable ...[to] throw a std::runtime_error"

[Stephen M. Webb (bregma)]

Simpler code is better, but see inline comment.

review: Needs Fixing

[Alan Griffiths (alan-griffiths)]

> Simpler code is better, but see inline comment.

fixed

[Mir CI Bot (mir-ci-bot)]

FAILED: Continuous integration, rev:3819
https://mir-jenkins.ubuntu.com/job/mir-ci/2154/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/2790/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2855
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2847
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2847
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2847
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2819/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2819
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2819/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2819
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2819/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2819
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2819/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2819
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2819/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2819
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2819/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2154/rebuild

review: Needs Fixing (continuous-integration)

[Stephen M. Webb (bregma)]

review: Approve

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:3820
https://mir-jenkins.ubuntu.com/job/mir-ci/2155/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2791
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2856
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2848
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2848
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2848
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2820/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2820/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2820/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2820/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2820/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2820
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2820/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2155/rebuild

review: Approve (continuous-integration)

[Andreas Pokorny (andreas-pokorny)]

ok

review: Approve

=== removed file 'src/include/server/mir/frontend/unsupported_feature_exception.h'
--- src/include/server/mir/frontend/unsupported_feature_exception.h	2014-09-18 09:18:01 +0000
+++ src/include/server/mir/frontend/unsupported_feature_exception.h	1970-01-01 00:00:00 +0000
@@ -1,41 +0,0 @@
-/*
- * Copyright © 2014 Canonical Ltd.
- *
- * This program is free software: you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * Authored by: Christopher James Halse Rogers <[e-mail]>
- */
-
-
-#ifndef MIR_FRONTEND_UNSUPPORTED_FEATURE_EXCEPTION_H_
-#define MIR_FRONTEND_UNSUPPORTED_FEATURE_EXCEPTION_H_
-
-#include <stdexcept>
-
-namespace mir
-{
-namespace frontend
-{
-class unsupported_feature : public std::runtime_error
-{
-public:
-    unsupported_feature()
-        : std::runtime_error{"Unsupported feature requested"}
-    {
-    }
-};
-}
-}
-
-
-#endif /* MIR_FRONTEND_UNSUPPORTED_FEATURE_EXCEPTION_H_ */

=== modified file 'src/server/frontend/protobuf_message_processor.cpp'
--- src/server/frontend/protobuf_message_processor.cpp	2016-10-12 06:03:15 +0000
+++ src/server/frontend/protobuf_message_processor.cpp	2016-11-11 17:55:37 +0000
@@ -22,7 +22,6 @@
 #include "mir/frontend/message_processor_report.h"
 #include "mir/frontend/protobuf_message_sender.h"
 #include "mir/frontend/template_protobuf_message_processor.h"
-#include "mir/frontend/unsupported_feature_exception.h"
 #include <mir/protobuf/display_server_debug.h>
 #include "mir/client_visible_error.h"
 
@@ -322,7 +321,7 @@
                 auto debug_interface = dynamic_cast<mir::protobuf::DisplayServerDebug*>(display_server.get());
                 invoke(this, debug_interface, &mir::protobuf::DisplayServerDebug::translate_surface_to_screen, invocation);
             }
-            catch (mir::frontend::unsupported_feature const&)
+            catch (std::runtime_error const&)
             {
                 std::string message{"Server does not support the client debugging interface"};
                 invoke(this,

=== modified file 'src/server/scene/unsupported_coordinate_translator.cpp'
--- src/server/scene/unsupported_coordinate_translator.cpp	2016-01-29 08:18:22 +0000
+++ src/server/scene/unsupported_coordinate_translator.cpp	2016-11-11 17:55:37 +0000
@@ -17,10 +17,11 @@
  */
 
 #include "unsupported_coordinate_translator.h"
-#include "mir/frontend/unsupported_feature_exception.h"
 
 #include <boost/exception/all.hpp>
 
+#include <stdexcept>
+
 namespace mg = mir::geometry;
 namespace mf = mir::frontend;
 namespace ms = mir::scene;
@@ -29,5 +30,5 @@
         std::shared_ptr<mf::Surface> /*surface*/,
         int32_t /*x*/, int32_t /*y*/)
 {
-    BOOST_THROW_EXCEPTION(mf::unsupported_feature());
+    BOOST_THROW_EXCEPTION(std::runtime_error{"Unsupported feature requested"});
 }