Code review comment for lp:~alan-griffiths/mir/fix-1577106

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I like it, but unrecoverable exceptions need to dump core too - per bug 1577106. Those are from 'throw' and not from 'fatal_error'. So if this lands, I don't think that's enough to say bug 1577106 is fixed. The bug might need to stay open.

Or did I miss something? Does this change also ensure unrecoverable exceptions leave core files too?

review: Needs Information

« Back to merge proposal