Mir

Merge lp:~alan-griffiths/mir/fix-1555074-again into lp:mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 3459
Proposed branch: lp:~alan-griffiths/mir/fix-1555074-again
Merge into: lp:mir
Diff against target: 11 lines (+1/-1)
1 file modified
tests/acceptance-tests/test_nested_mir.cpp (+1/-1)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1555074-again
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Cemil Azizoglu (community) Approve
Alexandros Frantzis (community) Approve
Kevin DuBois (community) Approve
Review via email: mp+291876@code.launchpad.net

Commit message

tests: increase timeout in NestedServer.display_orientation_changes_are_forwarded_to_host
(LP: #1555074)

Description of the change

tests: increase timeout in NestedServer.display_orientation_changes_are_forwarded_to_host

This is the same fix that landed in -r 3402

C.f. lp:~alan-griffiths/mir/fix-1555074/+merge/289366

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

FWIW:

$ bzr diff -c 3444 | grep --context 2 "config_reported.wait_for(std::chrono::seconds{1});"

- condition.wait_for_at_most_seconds(3);
+ config_reported.wait_for(std::chrono::seconds{1});
         Mock::VerifyAndClearExpectations(the_mock_display_configuration_report().get());

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3458
https://mir-jenkins.ubuntu.com/job/mir-ci/834/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/841/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/878
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/869
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/869
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/851
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/851/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/851
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/851/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/851
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/851/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/851
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/851/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/851/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/834/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Unrelated failure logged as lp:1570353

Revision history for this message
Kevin DuBois (kdub) wrote :

alright

review: Approve
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/200/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/846/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/212/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/883
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/874
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/874
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/856
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/856/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/856
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/856/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/856
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/856/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/856
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/856/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/856/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

ok

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/acceptance-tests/test_nested_mir.cpp'
2--- tests/acceptance-tests/test_nested_mir.cpp 2016-04-11 16:56:16 +0000
3+++ tests/acceptance-tests/test_nested_mir.cpp 2016-04-14 10:45:33 +0000
4@@ -712,7 +712,7 @@
5
6 mir_wait_for(mir_connection_apply_display_config(client.connection, configuration));
7
8- config_reported.wait_for(std::chrono::seconds{1});
9+ config_reported.wait_for(std::chrono::seconds{3});
10 Mock::VerifyAndClearExpectations(the_mock_display_configuration_report().get());
11 }
12

Subscribers

People subscribed via source and target branches