Mir

Merge lp:~alan-griffiths/mir/fix-1503450 into lp:mir

Proposed by Alan Griffiths on 2015-10-07
Status: Merged
Approved by: Chris Halse Rogers on 2015-10-07
Approved revision: 3003
Merged at revision: 3005
Proposed branch: lp:~alan-griffiths/mir/fix-1503450
Merge into: lp:mir
Diff against target: 33 lines (+3/-3)
2 files modified
include/platforms/mesa/mir_toolkit/mesa/native_display.h (+1/-1)
src/platforms/mesa/mir-client-platform-mesa.pc.in (+2/-2)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1503450
Reviewer Review Type Date Requested Status
Chris Halse Rogers Approve on 2015-10-07
Tiago Stürmer Daitx (community) 2015-10-07 Approve on 2015-10-07
Kevin DuBois (community) Approve on 2015-10-07
PS Jenkins bot (community) continuous-integration Approve on 2015-10-07
Andreas Pokorny (community) 2015-10-07 Approve on 2015-10-07
Review via email: mp+273668@code.launchpad.net

Commit message

mir-client-platform-mesa: declare MirBufferPackage in mir_toolkit/mesa/native_display.h.

Description of the change

mir-client-platform-mesa: declare MirBufferPackage in mir_toolkit/mesa/native_display.h.

I.e. do not include mir_toolkit/mir_native_buffer.h to define it as that header belongs to libmircommon-dev which should not need to be a dependency.

To post a comment you must log in.
lp:~alan-griffiths/mir/fix-1503450 updated on 2015-10-07
3001. By Alan Griffiths on 2015-10-07

And the missing mirclient dependency

Andreas Pokorny (andreas-pokorny) wrote :

DNS failure krillin-09.. at least the types of failures keep varying..

lgtm

review: Approve
lp:~alan-griffiths/mir/fix-1503450 updated on 2015-10-07
3002. By Alan Griffiths on 2015-10-07

merge lp:mir

3003. By Alan Griffiths on 2015-10-07

Drop duplication with mirclient.pc

Kevin DuBois (kdub) wrote :

ok

Kevin DuBois (kdub) :
review: Approve
Tiago Stürmer Daitx (tdaitx) wrote :

I can approve the following piece for LP: #1503450

+Requires.private: mirclient

Everything else depends on Mir developers (and I am not one). =)

review: Approve
Chris Halse Rogers (raof) wrote :

Seems sensible.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/platforms/mesa/mir_toolkit/mesa/native_display.h'
2--- include/platforms/mesa/mir_toolkit/mesa/native_display.h 2015-09-15 17:13:45 +0000
3+++ include/platforms/mesa/mir_toolkit/mesa/native_display.h 2015-10-07 13:06:34 +0000
4@@ -18,7 +18,6 @@
5 #ifndef MIR_TOOLKIT_MESA_NATIVE_DISPLAY_H
6 #define MIR_TOOLKIT_MESA_NATIVE_DISPLAY_H
7
8-#include <mir_toolkit/mir_native_buffer.h>
9 #include <mir_toolkit/client_types.h>
10
11 #define MIR_MESA_TRUE 1
12@@ -35,6 +34,7 @@
13
14 typedef struct MirMesaEGLNativeDisplay MirMesaEGLNativeDisplay;
15 typedef struct MirMesaEGLNativeSurface MirMesaEGLNativeSurface;
16+typedef struct MirBufferPackage MirBufferPackage;
17
18 struct MirMesaEGLNativeDisplay
19 {
20
21=== modified file 'src/platforms/mesa/mir-client-platform-mesa.pc.in'
22--- src/platforms/mesa/mir-client-platform-mesa.pc.in 2015-09-24 22:30:09 +0000
23+++ src/platforms/mesa/mir-client-platform-mesa.pc.in 2015-10-07 13:06:34 +0000
24@@ -1,7 +1,7 @@
25 includedir=@INCLUDEDIR@/mirplatform
26-common_includedir=@INCLUDEDIR@/mircommon
27
28 Name: mir-client-platform-mesa
29 Description: Mir Mesa client platform development files
30 Version: @MIR_VERSION@
31-Cflags: -I${includedir} -I${common_includedir}
32+Requires.private: mirclient
33+Cflags: -I${includedir}

Subscribers

People subscribed via source and target branches