Mir

Merge lp:~alan-griffiths/mir/fix-1284554 into lp:mir

  1. fix-1284554
  2. Merge into development-branch
Proposed by Alan Griffiths
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1426
Proposed branch: lp:~alan-griffiths/mir/fix-1284554
Merge into: lp:mir
Diff against target: 13 lines (+1/-2)
1 file modified
examples/demo-shell/demo_shell.cpp (+1/-2)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1284554
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Approve
Alexandros Frantzis (community) Approve
Review via email: mp+208099@code.launchpad.net

Commit message

examples: correct "fullscreen-surfaces" option

Description of the change

examples: correct "fullscreen-surfaces" option

To post a comment you must log in.
Revision history for this message
Alexandros Frantzis (afrantzis) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1422
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/934/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1035
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1033
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/627
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/664/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/671
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/671/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/628
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/628/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/602
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4274

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/934/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Works for me. Though I don't really understand why, looking at the diff :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/demo-shell/demo_shell.cpp'
2--- examples/demo-shell/demo_shell.cpp 2014-02-21 11:06:03 +0000
3+++ examples/demo-shell/demo_shell.cpp 2014-02-25 10:19:57 +0000
4@@ -53,8 +53,7 @@
5 namespace po = boost::program_options;
6
7 result->add_options()
8- ("fullscreen-surfaces", po::value<bool>()->default_value(false),
9- "Make all surfaces fullscreen");
10+ ("fullscreen-surfaces", "Make all surfaces fullscreen");
11
12 return result;
13 }()),

Subscribers

People subscribed via source and target branches