I think changing our behaviour based on os-release is a mistake. In particular, I'm pretty sure this won't build on anything but Fedora, or Debian-derived distros, but it would be possible to do feature-detection that *would* work everywhere instead.
It looks like:
*) miral-check-symbols should use and be dependent on find_program(DPKG_GENSYMBOLS dpkg-gensymbols)
*) The MIRAL_DEFAULT_FONT_FILE should be something like
find_file(
MIRAL_DEFAULT_FONT_FILE
NAMES Ubuntu-B.ttf FreeSansBold.ttf
DOC "Font to be used in titlebars by miral-shell"
PATHS /usr/share/fonts/truetype
PATH_SUFFIXES ubuntu-font-family freefont)
...and the capnproto differences are due to the Debian packages shipping a homebrew CMake integration. Urgh. I'll fix the Ubuntu package, and submit a patch to Debian, and try and work out how to detect the b0rkage.
From the documentation I think the target_link_libraries should be
target_link_libraries(mircapnproto CapnProto::capnp-rpc)
I think changing our behaviour based on os-release is a mistake. In particular, I'm pretty sure this won't build on anything but Fedora, or Debian-derived distros, but it would be possible to do feature-detection that *would* work everywhere instead.
It looks like: DPKG_GENSYMBOLS dpkg-gensymbols) FONT_FILE should be something like DEFAULT_ FONT_FILE fonts/truetype
*) miral-check-symbols should use and be dependent on find_program(
*) The MIRAL_DEFAULT_
find_file(
MIRAL_
NAMES Ubuntu-B.ttf FreeSansBold.ttf
DOC "Font to be used in titlebars by miral-shell"
PATHS /usr/share/
PATH_SUFFIXES ubuntu-font-family freefont)
...and the capnproto differences are due to the Debian packages shipping a homebrew CMake integration. Urgh. I'll fix the Ubuntu package, and submit a patch to Debian, and try and work out how to detect the b0rkage.
From the documentation I think the target_ link_libraries should be link_libraries( mircapnproto CapnProto: :capnp- rpc)
target_