Code review comment for lp:~alan-griffiths/mir/even-NullWindowManager-configures-surface

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Come to think of it, establishing new precedent is important. Because people often refer to precedent and consistency in their reasoning. Even as a reason to reject more simplistic and maintainable designs. So we need to break the mold ASAP.

In cases like this where a class used in production is kind of like Null, kind of like Stub, and very much useful in its bare form, I think this is where those prefixes (including Skeleton) should not be used. So rename SkeletonWindowManager -> WindowManager and remove the existing pure virtual one.

This not only results in less typing, but fewer classes and less maintenance. As "Null" and "Stub" forms need never exist (they do implicitly). You can still add a Mock form later if required.

review: Needs Fixing

« Back to merge proposal