Merge lp:~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring into lp:mir
Proposed by
Alan Griffiths
Status: | Rejected |
---|---|
Rejected by: | Alan Griffiths |
Proposed branch: | lp:~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring |
Merge into: | lp:mir |
Diff against target: |
257 lines (+82/-81) 2 files modified
src/server/compositor/multi_threaded_compositor.cpp (+80/-79) tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+2/-2) |
To merge this branch: | bzr merge lp:~alan-griffiths/mir/does-jenkins-like-MultiThreadedCompositor-refactoring |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Mir CI Bot | continuous-integration | Approve | |
Mir development team | Pending | ||
Review via email: mp+284079@code.launchpad.net |
Commit message
compositor: clearer logic for MultiThreadedCo
Description of the change
compositor: clearer logic for MultiThreadedCo
This should be a pure refactoring extracted from lp:~alan-griffiths/mir/better-error-reporting-in-MultiThreadedCompositor-start (as I've not identified the problem causing CI failures there).
To post a comment you must log in.
Unmerged revisions
- 3276. By Alan Griffiths
-
Experiment to diagnose Jenkins failures
- 3275. By Alan Griffiths
-
Report errors starting compositor threads by propagating exception from start()
- 3274. By Alan Griffiths
-
Don't mix level of abstraction within a function
PASSED: Continuous integration, rev:3274 /mir-jenkins. ubuntu. com/job/ mir-ci/ 166/ /mir-jenkins. ubuntu. com/job/ generic- update- mp/166/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 166/rebuild
https:/